Skip to content

Fixing PIQA implementation #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 25, 2024
Merged

Fixing PIQA implementation #222

merged 4 commits into from
Jul 25, 2024

Conversation

@clefourrier
Copy link
Member

@clefourrier clefourrier commented Jul 11, 2024 •
edited
Loading

  • updates to new dataset path
  • changes generative length to 1 since we need to generate A or B

Fix #198

@clefourrier clefourrier requested a review from NathanHB July 11, 2024 12:00
@clefourrier clefourrier merged commit 506abda into main Jul 25, 2024
hynky1999 pushed a commit that referenced this pull request May 22, 2025
@clefourrier @NathanHB
udpated piqa (#222)
e51a00c 
Co-authored-by: Nathan Habib <[email protected]>
NathanHB added a commit that referenced this pull request Sep 19, 2025
@clefourrier @NathanHB
udpated piqa (#222)
9662777 
Co-authored-by: Nathan Habib <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NathanHB NathanHB NathanHB approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The helm|piqa task is generative but has generation_size=-1.

3 participants

@clefourrier @NathanHB